Attention is currently required from: Thomas Heijligen, Angel Pons.
View Change
1 comment:
Patchset:
Patch Set #1:
It doesn't seem trivial to say how this makes things better. I can
see that for the removed #endif/#ifdef` pairs, but not for everything.
IMO, we should put such things into individual header files eventually.
So should we maybe do that right away and skip shuffling things around?
(which would only make the Git history harder to follow)
To view, visit change 63468. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0dcdb6c7998eec36e619f6e5c82825f60a2435ac
Gerrit-Change-Number: 63468
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Mon, 11 Apr 2022 10:36:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment