[flashrom-gerrit] [M] Change in flashrom[main]: erasure_layout: Add an option to sacrifice unchanged blocks for speed

[Peter Marheine (Code Review)]

Attention is currently required from: Aarya, Anastasia Klimchuk, Bill XIE.

Peter Marheine has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84721?usp=email )

Change subject: erasure_layout: Add an option to sacrifice unchanged blocks for speed
......................................................................


Patch Set 10:

(2 comments)

File doc/classic_cli_manpage.rst:

https://review.coreboot.org/c/flashrom/+/84721/comment/a3d79336_431c45f2?usp... :
PS10, Line 23: |         [-V[V[V]]] [-o <logfile>] [--progress][--sacrifice-ratio <ratio>]
Add a space between flags.

```suggestion
|         [-V[V[V]]] [-o <logfile>] [--progress] [--sacrifice-ratio <ratio>]
```


File doc/release_notes/devel.rst:

https://review.coreboot.org/c/flashrom/+/84721/comment/905d7b53_a095bf8a?usp... :
PS10, Line 57: didn't need to be erased. Which means, the chip, as a hardware, will
             : wear faster.
             : 
             : New command line option sets the maximum % memory that is allowed for
             : redundant erase. Default is 0, S+1 size block only selected if all the
             : area needs to be erased in full. 50 means that if more than a half of
             : the area needs to be erased, a S+1 size block can be selected to cover
             : all area with one block.
Small rewording suggestions.

```suggestion
didn't need to be erased. Which means the physical chip will wear out
faster.

This new option sets the maximum % of memory that is allowed for
redundant erase. Default is 0, S+1 size block only selected if all the
area needs to be erased in full. 50 means that if more than a half of
the area needs to be erased, a S+1 size block can be selected to cover
the entire area with one block.
```



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/84721?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I154e8a713f626c37dbbe118db700055b96d24803
Gerrit-Change-Number: 84721
Gerrit-PatchSet: 10
Gerrit-Owner: Bill XIE <[e-mail]>
Gerrit-Reviewer: Aarya <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Peter Marheine <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Bill XIE <[e-mail]>
Gerrit-Attention: Aarya <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Comment-Date: Tue, 29 Oct 2024 02:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No