Attention is currently required from: Subrata Banik, Angel Pons, Anastasia Klimchuk.

View Change

2 comments:

• Commit Message:

  • Patch Set #6, Line 10: during the data portion of the SPI cycle.

    > What's the reasoning for this change? The commit message doesn't explain *why* this change would b […]

    This sounds a bit like a personal preference to name macros. I'm usually
    in favor to allow authors some flexibility to give the code their own
    touch and to show respect to the original author(s) by not changing the
    style to ones own taste.

• File ichspi.c:

  • Patch Set #4, Line 508: FDBC

    > > Hmmm, if the new macro name doesn't work nicely with the existing code, maybe it wasn't meant to […]

    Subrata, as it's a macro, you can always simply run the file through a
    preprocessor to test if the output changes.

    The original use of _pprint_reg() is flawed, though. Anastasia is right
    about the bit vs. reg parameter. As it's very error-prone, how about we
    get rid of _pprint_reg() again and add an optional argument (for the
    PCH100_ prefix) to pprint_reg() instead. It seems possible, didn't try.

To view, visit change 62894. To unsubscribe, or for help writing mail filters, visit settings.