Patch Set 13:

(5 comments)

Uh, this is quite large to review in one go. Could you please split this into steps?

The commit message has two rather long paragraphs. I'd put them (and the corresponding changes) in separate commits

Yes, I will break it up into separate commits.

View Change

2 comments:

• File raiden_debug_spi.c:

  • Patch Set #13, Line 149:

    using tabs here instead of spaces would make it easier to keep the alignment. […]

    There's pros and cons to using either spaces or tabs for alignment. Tabs allow consistent alignment if everyone uses the same width, but only about half of developers use any particular style. This convention takes slightly more effort when writing, but allows developers to optimize tab size to what they regard as comfortable to read which is done far more.

  • Patch Set #13, Line 158: We too much data.

    Missing a verb?

    Yes, it should be 'The host received more data than can fit in read buffer'

To view, visit change 41608. To unsubscribe, or for help writing mail filters, visit settings.