Attention is currently required from: Nico Huber.
View Change
1 comment:
File writeprotect.c:
Patch Set #1, Line 159: new
I don't quite follow, how can it be expected? Should the flash chip […]
I'm also not sure if test terminology is more appropriate here than old/new or current/new, but one can think of "expected" meaning "state expected at the end of the operation".
To view, visit change 66754. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I81d2d3fc0a103ee00ced78838d77fe33a9d3056a
Gerrit-Change-Number: 66754
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Fri, 07 Oct 2022 12:35:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-MessageType: comment