Attention is currently required from: Angel Pons, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim.

View Change

3 comments:

• File flashchips.c:

  • Patch Set #4, Line 6415: FEATURE_4BA_WREN

    I don't think that this chip requires WREN before setting 4 bit addressing.

    It also supports QPI, so I think this should be:

    ```
    FEATURE_QPI | FEATURE_4BA
    ```

  • Patch Set #4, Line 6434: .eraseblocks = { {64 * 1024, 1024} },

    It looks like we lost the .block_erase identifier:

    ```
    .eraseblocks = { {64 * 1024, 1024} },
    .block_erase = spi_block_erase_dc,
    ```

  • Patch Set #4, Line 6450: .voltage = {1600, 2000},

    Maybe add the register bits?  I think this is right:
    ```
    .reg_bits       =
                    {
                            .srp    = {STATUS1, 7, RW},
                            .bp     = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}},
                            .tb     = {STATUS1, 6, RW},
                    },
    ```

To view, visit change 58025. To unsubscribe, or for help writing mail filters, visit settings.