Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner.

12 comments:

Patchset:
- Patch Set #4:
  Yeah, I started some work on the Super I/O is preceding patch: 55849 […]
  Now I probe only for ITE Super I/Os. Just added more model IDs in the switch to catch the supported chips. Redesigning Super I/O code needs more thought and I won't pursue it right now. DMI checks have been replaced with PCI ID and SSID checks to not depend on any dmidecoder (which may fail depending on UEFI vs legacy).
Patchset:
- Patch Set #11:
  Ack
  Changed the name to ite_ecfw
File Makefile:
- Patch Set #1, Line 409:
```
ifeq ($(CONFIG_TUXEDO_EC), yes)
UNSUPPORTED_FEATURES += CONFIG_TUXEDO_EC=yes
else
override CONFIG_TUXEDO_EC = no
endif
```
  Currently there is no coreboot (and libpayload) support for Tuxedo laptops, thus it is disabled here […]
  Ack
- Patch Set #1, Line 903: # Disable internal DMI decoder to be able to locate DMI tables on EFI systems and match TUXEDO laptops
  The TUXEDO laptops currenlty come with an UEFI firmware from IBV, no CSM support, so the only way to […]
  DMI checks have been replaced with PCI ID and SSID checks
File flashrom.8.tmpl:
- Patch Set #1, Line 1399: autoloading
  I can only guess. […]
  Elaborated a bit on this in the man entry
- Patch Set #1, Line 1411: ite5570
  The code automatically detects ITE5570, however it can be forcefully set as in the reference impleme […]
  Removed the option to force IT5570. It is automatically detected and selected right now and it should suffice.
File flashrom.c:
- Patch Set #1, Line 2109: #if CONFIG_TUXEDO_EC == 1
  > The coreboot check above is a very bad rolemodel. It does things flashrom shouldn't […]
  For now I have left this function as global API. It works as expected and can be included in any future programmer API if needed.

File ite_ec.c:

	if (!ec_write_reg(0xf9, 0x20, EC_MAX_STATUS_CHECKS) ||
	    !ec_write_reg(0xfa, 0x02, EC_MAX_STATUS_CHECKS) ||
	    !ec_write_reg(0xfb, 0x00, EC_MAX_STATUS_CHECKS) ||
	    !ec_write_reg(0xf8, 0xb1, EC_MAX_STATUS_CHECKS)) {
		msg_perr("Unable to initialize controller.\n");
		return 1;
	}

I found out what this does: […]

Added a separate function for this purpose. Please check

File ite_ec.c:
- Patch Set #13, Line 53: controlls the flash mirroring
  nit: controls flash mirroring
  Done
- Patch Set #13, Line 78: struct ite_string {
  L140CU signatures: […]
  Added some structure defining those bits. Please check
- Patch Set #13, Line 314: 0x06
  EC_CMD_WRITE_KBYTE
  Done
- Patch Set #13, Line 554: p = extract_programmer_param("ite5570");
  I am already detecting it. You may be right that there is no use for it anymore.
  Removed the programmer option to set the it5570 by the user.

To view, visit change 55715. To unsubscribe, or for help writing mail filters, visit settings.