Attention is currently required from: Hsuan-ting Chen, Nikolai Artemiev, Stefan Reinauer.
2 comments:
File flashchips.c:
Patch Set #1, Line 6802: /* FIXME: 128E's OTP: 3072B total and doesn't support QPI */
I have two questions about these: […]
1. Yes, I think you need to separate the two chip definitions. This is what I meant when I said you need to split. You can copypaste existing definition into new one, make necessary changes and adjustments, and put new the one in alphabetical order.
At the end there will be two definitions instead of one that it now.
Also you will need to update the commit title.
2. If there are 3 different chips with the same IDs, you will need to provide chip name with `-c` or `--chip` options (you can check this option on man page which is also on the web page https://flashrom.org/classic_cli_manpage.html#options)
.reg_bits =
{
.srp = {STATUS1, 7, RW},
.srl = {STATUS2, 0, RW},
.bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}},
.tb = {STATUS1, 5, RW}, /* Called BP3 in datasheet, acts like TB */
.sec = {STATUS1, 6, RW}, /* Called BP4 in datasheet, acts like SEC */
.cmp = {STATUS2, 6, RW},
}
> Are all these registers the same for new chip you are adding […]
Great thank you!
To view, visit change 78348. To unsubscribe, or for help writing mail filters, visit settings.