Attention is currently required from: Felix Singer, Edward O'Callaghan.
View Change
2 comments:
File rayer_spi.c:
Patch Set #2, Line 264: *prog_type = strdup(arg);
As mentioned in CB:68230, calling `get_progtype()` here and having this function "return" the prog t […]
CB:68239 does it
Patch Set #2, Line 271: static const struct rayer_programmer *find_progtype(const char *prog_type)
If you want to keep CB:68239 as a separate commit, could you please move this function above `get_params()`?
To view, visit change 68238. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id226ea61132ecc30fd8696e1d8ea50373e752cac
Gerrit-Change-Number: 68238
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Sat, 08 Oct 2022 13:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment