Attention is currently required from: Nico Huber, Angel Pons.
View Change
1 comment:
File mec1308.c:
Patch Set #1, Line 115: #endif /* UNIT_TEST_ENV */
I know it won't be as easy, but I'd much prefer such mocks in […]
I was thinking about separate compilation units for a while, how exactly to do this. Maybe you have some concrete ideas in mind?
All that inb/outb functionality is in hwaccess.h. Can we have a hwaccess_unittest.h for test environment? Although it does not solve the question because for every driver needs its own mocking. For example mec1308 in this patch expects specific value from inb, not just any value.
To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3af612defe1af3850dfc1626a208d873e3a3eddc
Gerrit-Change-Number: 51487
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 22:27:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment