Patch set 2:Code-Review -1
View Change
1 comment:
File cli_classic.c:
Patch Set #1, Line 67: " --loop-delay get show loop delay calibration\n"
I would suggest to rename the --loop-delay get to --get-loop-delay because I see no other arguments […]
I agree with Miklós... `--loop-delay get` is a somewhat different syntax than we've used in the past, so it's probably better to stay consistent.
To view, visit change 39841. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iea2a7f62300663bc0a32ed4abced57c8c55c90c8
Gerrit-Change-Number: 39841
Gerrit-PatchSet: 2
Gerrit-Owner: Hrvoje Čavrak <github@hrvoje.org>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 26 Mar 2020 04:15:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-MessageType: comment