Attention is currently required from: Peter Marheine.

View Change

1 comment:

• File util/flashrom_tester/flashrom/src/cmd.rs:

  • Patch Set #6, Line 73: Option

    This still seems weird, in that it's required to specify either a file or a region with some file. […]

    your 3 cases are not quite right, these are the two modes flashrom accepts:

    ```
    a file and an array of regions with optional files
    a region with a file, and an array of regions with optional files
    ```

    or reworded like yours

    ```
    One file, entire chip
    Multiple files, one per part of chip (+ optional whole chip sized file with part of chip) (all but one file is optional)
    ```

    I only ever have one region, so:

    ```
    a file and an optional region with optional file
    a region with a file
    ```

    But we only use these:

    ```
    a file
    a file and a region
    a region with a file
    ```

    I will try the last one, it makes the output logic a little more complex

To view, visit change 71973. To unsubscribe, or for help writing mail filters, visit settings.