Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
4 comments:
Patchset:
But this is a good idea: `list_programmers_linebreak` iterates through programmers names, which is e […]
One moment please, ```list_programmers_linebreak``` has a different meaning. It does not prepare the list for external usage, it prints the list to the logger only, assuming line breaks/startcol/cols/paren. But I need just an array of strings and this is a simple loop through. It is not heavy in order to reuse something.
Iterator has its meaning from this comment https://review.coreboot.org/c/flashrom/+/86921/comment/305f6656_3d9d7212/
The issue is that I had to allocate the memory and Peter wanted to prevent it but we already use an allocation in all other get_supported.. functions. Therefore we decided to leave this implementation plus to implement fn like this in next commit
```
const char *flashrom_get_programmer_name(int n)
{
if (n < 0 || (size_t)n >= programmer_table_size)
return NULL;
return programmer_table[n]->name;
}
```
I probably confused you with the deleting of commits. It is my fault. My git for some reason squashes commit when I set to edit it. But lets discuss only what we have here please.
Commit Message:
Patch Set #10, Line 7: libflashrom: Added API to enumerate supported programmers
This title we changed earlier as […]
Done
File libflashrom.c:
no space here
Done
File tests/libflashrom.c:
Patch Set #10, Line 109: while (*(ptr++)) {}
Maybe you can assert inside the loop that programmer name is not empty string (unless it's the last […]
Done
To view, visit change 86921. To unsubscribe, or for help writing mail filters, visit settings.