Nico Huber posted comments on this change.
View Change
Patch set 1:
Don't see that the hidden behavioural change deserves a fixup. Let
me know if you have strong feelings about that.
(1 comment)
File Makefile:
Patch Set #1, Line 554: $(shell ./util/getrevision.sh -c 2>/dev/null && ./util/git-hooks/install.sh)
The only behavioural change I can spot is that this is now also
done when both Makefile.VCS and git are available.
To view, visit change 21827. To unsubscribe, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedc9df4c033a70447b8b1b65c83764c769b02c3f
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 02 Oct 2017 11:45:44 +0000
Gerrit-HasComments: Yes