Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Thomas Heijligen.
3 comments:
Commit Message:
3 or 4? From the patch it seems like 4. […]
The patch adds support for older 3.x versions, since 4.x and newer exhibit the [naturally] expected behavior.
Patch Set #3, Line 10: 7996 and 9217
This is very useful info, but you would need to add full links to GitHub issues (so that it's easier […]
Acknowledged
but not on `sphinx-build` own level
upon which `meson` build relies
I don't fully understand this last part of the sentence, what does it mean "not on sphinx-build own […]
doc/meson.build contains the following:
`build_always_stale : true, # sphinx handles rebuilds`
It means that `sphinx-build` is always run by `meson`, and that utility itself decides whether a man page should be rebuild — not the `meson` build system. When we rename the "8" directory that is created by `sphinx-build` 3.x to "man8" directory that is expected by doc/meson.build, we effectively break `sphinx-build` ability to avoid future rebuilds. (This is unlike with `make` that handles dependencies by itself, as specified in Makefile.)
Alternatively, a symlink "8" may be created pointing at "man8" after the directory renaming occurs. Or "man8" may be created as a hardlink to "8". In that case `sphinx-build` 3.x would be able to avoid unnecessary rebuilds. I just didn't think it might be necessary, given the small build time and a single man page only; but should you consider it worth the efforts, I will try to implement that trick (not totally sure whether it will have the desired effect, though).
To view, visit change 77778. To unsubscribe, or for help writing mail filters, visit settings.