Attention is currently required from: Khem Raj.

1 comment:

Patchset:
- Patch Set #1:
  I wonder if Iaa4477a71e758cf9ecad2c22f3b77bc6508a3510 fixes it too, Pyro was it similar issue you we […]
  I think it does, it looks like it's been taken care of. Although, Pyro's solution
  relies on the assumption that we really only need the last line of the output.
  Hmm, yours does too, I'd switch `tail` and `grep`, e.g.
```
    grep '"' | tail -1 | cut -f 2 -d'"'
```
  Not sure, though, if it's worth another patch.
  Personally, I'm a fan of the `awk` tool. It let's you do multiple things in
  one program while still being rather simple. e.g. for the same result:
```
    awk -v FS=\" '/"/ { p = $2; } END { print p; }'
```
  Also, I wonder what the unfiltered output of `cc -E os.h` looks like for
  you. Maybe there is a better pattern to check for.

To view, visit change 43770. To unsubscribe, or for help writing mail filters, visit settings.