>> Code looks good, how well was the rebase tested?
>
> After I've tested the code and submitted these ported patches, the
> only rebase was because of a small typo fix at one of the commit
> messages, so the results are still positive - fully tested on the
> real hardware

I meant the original rebase of Paul's work. What is "the real hard-
ware"? It should be primarily tested on previously supported pro-
grammers and flash chips to make sure nothing regresses.

View Change

3 comments:

To view, visit change 23258. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b0de8568e31f9bf263ba0ad6b051e837477b6b
Gerrit-Change-Number: 23258
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 02 Feb 2018 22:04:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No