David Hendricks merged this change.

View Change

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
ich_descriptors: Use MAX_NUM_FLREGS for entries[]

5 regions made sense in 2013 when this bit of code was originally
written. MAX_NUM_FLREGS is now used to keep track of the max number of
flash regions and is >5 since Sunrise Point.

Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38
Signed-off-by: David Hendricks <dhendricks@fb.com>
Reviewed-on: https://review.coreboot.org/21338
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
---
M ich_descriptors.h
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ich_descriptors.h b/ich_descriptors.h
index 9a16031..db4d28f 100644
--- a/ich_descriptors.h
+++ b/ich_descriptors.h
@@ -568,7 +568,7 @@

struct ich_layout {
struct flashrom_layout base;
- struct romentry entries[5];
+ struct romentry entries[MAX_NUM_FLREGS];
};

ssize_t ich_number_of_regions(enum ich_chipset cs, const struct ich_desc_content *content);

To view, visit change 21338. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38
Gerrit-Change-Number: 21338
Gerrit-PatchSet: 4
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>