Attention is currently required from: Angel Pons, Anastasia Klimchuk, Simon Glass.
View Change
1 comment:
File tests/io_mock.h:
Patch Set #13, Line 37: unsigned char
I took these types from hwaccess_x86_io. […]
Hmmm, the functions there are only implemented for Net and OpenBSD. I don't
know why it uses stdint types. Probably just because somebody wanted to be
correct (the stdint types are more precise, regular int types are easier to
optimize for a compiler).
It's not breaking anything. Just feels odd.
To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3af612defe1af3850dfc1626a208d873e3a3eddc
Gerrit-Change-Number: 51487
Gerrit-PatchSet: 14
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Simon Glass <sjg@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Simon Glass <sjg@chromium.org>
Gerrit-Comment-Date: Tue, 11 May 2021 16:24:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment