Edward O'Callaghan submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved
sb600spi.c: Drop sb600_ prefix for spi data struct member

The name of the struct type already contains sb600spi_ prefix, so
prefix doesn't need to be repeated in members name.

BUG=b:185191942
TEST=builds

Change-Id: I001ae2044453d1bc205fa253ffb773ed993f57f8
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/54714
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
---
M sb600spi.c
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sb600spi.c b/sb600spi.c
index 32071b9..c057947 100644
--- a/sb600spi.c
+++ b/sb600spi.c
@@ -56,7 +56,7 @@

struct sb600spi_data {
struct flashctx *flash;
- uint8_t *sb600_spibar;
+ uint8_t *spibar;
};

static int find_smbus_dev_rev(uint16_t vendor, uint16_t device)
@@ -207,7 +207,7 @@
unsigned char *readarr)
{
struct sb600spi_data *sb600_data = flash->mst->spi.data;
- uint8_t *sb600_spibar = sb600_data->sb600_spibar;
+ uint8_t *sb600_spibar = sb600_data->spibar;
/* First byte is cmd which can not be sent through the FIFO. */
unsigned char cmd = *writearr++;
writecnt--;
@@ -295,7 +295,7 @@
unsigned char *readarr)
{
struct sb600spi_data *sb600_data = flash->mst->spi.data;
- uint8_t *sb600_spibar = sb600_data->sb600_spibar;
+ uint8_t *sb600_spibar = sb600_data->spibar;
/* First byte is cmd which can not be sent through the buffer. */
unsigned char cmd = *writearr++;
writecnt--;
@@ -784,7 +784,7 @@
}

data->flash = NULL;
- data->sb600_spibar = sb600_spibar;
+ data->spibar = sb600_spibar;

register_shutdown(sb600spi_shutdown, data);


To view, visit change 54714. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I001ae2044453d1bc205fa253ffb773ed993f57f8
Gerrit-Change-Number: 54714
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged