Angel Pons submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
tests: Clear ID cache before trying to fetch chip ID a second time

Without that, the code never calls into spi_send_command (because
everything's known already) and so the expected return values are
never returned.

Change-Id: Iba6a56774ce5b51e0f7072b4600a9479cdabf8c7
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/45431
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M tests/spi25.c
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/tests/spi25.c b/tests/spi25.c
index aa1eea0..362f5c6 100644
--- a/tests/spi25.c
+++ b/tests/spi25.c
@@ -129,6 +129,7 @@
(void) state; /* unused */

/* setup initial test state. */
+ clear_spi_id_cache();
struct flashctx flashctx = { .chip = &mock_chip };
expect_memory(__wrap_spi_send_command, flash,
&flashctx, sizeof(flashctx));

To view, visit change 45431. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iba6a56774ce5b51e0f7072b4600a9479cdabf8c7
Gerrit-Change-Number: 45431
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged