Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine.

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    Not sure if anybody checked that there is no NULL pointer introduced […]

    When I checked, `extract_programmer_param_str()` was always called with a `cfg` argument. I did not check if it's null nor where it comes from.

• File flashrom.c:

  • Patch Set #1, Line 297: &

    That this is a pointer inside a const struct and works made me realize […]

    Sounds like a good idea

To view, visit change 67649. To unsubscribe, or for help writing mail filters, visit settings.