Edward O'Callaghan merged this change.

View Change

Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
flashchips.c: Add comma after every .voltage attribute

To allow automated tools to manipulate flashchips.c, ensure that every
voltage attribute ends with a comma, even if it is the last member in
the definition.

Signed-off-by: Alan Green <avg@google.com>
Change-Id: Ie609d11ab846361f375f7b024d6ca55f83b01682
Reviewed-on: https://review.coreboot.org/c/flashrom/+/33832
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
---
M flashchips.c
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/flashchips.c b/flashchips.c
index ac65510..ad7ecd7 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -525,7 +525,7 @@
},
.write = write_jedec_1,
.read = read_memmapped,
- .voltage = {3000, 3600} /* 3.0-3.6V for type -70R, others 2.7-3.6V */
+ .voltage = {3000, 3600}, /* 3.0-3.6V for type -70R, others 2.7-3.6V */
},

{
@@ -557,7 +557,7 @@
},
.write = write_jedec_1,
.read = read_memmapped,
- .voltage = {3000, 3600} /* 3.0-3.6V for type -70R, others 2.7-3.6V */
+ .voltage = {3000, 3600}, /* 3.0-3.6V for type -70R, others 2.7-3.6V */
},

{

To view, visit change 33832. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie609d11ab846361f375f7b024d6ca55f83b01682
Gerrit-Change-Number: 33832
Gerrit-PatchSet: 12
Gerrit-Owner: Alan Green <avg@google.com>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged