Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.

Patch set 7:Code-Review +1

View Change

2 comments:

• Patchset:

  • Patch Set #7:

    I wanted to ask, is the end goal to remove usage of __FLASHROM_LITTLE_ENDIAN__ and __FLASHROM_BIG_ENDIAN__ ? Not in the patch of course, but in future: it looks like a patch is going in the direction to remove them?
    The patch looks all good.

• File hwaccess.h:

  • Patch Set #6, Line 28: swap

    I thought to swap (with the meaning of exchange) is a better wording. I'm not fixed with it.

    I agree this is better wording. I was just checking this is intentional, and looks like it is. Marking as resolved.

To view, visit change 62898. To unsubscribe, or for help writing mail filters, visit settings.