Attention is currently required from: Nico Huber, Angel Pons, Julius Werner.
View Change
2 comments:
File fmap.c:
Patch Set #1, Line 99: if (len == 0)
+1 we should simply check that the calculation below doesn't overflow.
sure, the predicate is more precisely:
`if ((len < sizeof(struct fmap)) return -1;`
Patch Set #1, Line 102: (off_t)(len - sizeof(struct fmap)
Hrmm, I added this cast at some point, but it doesn't seem to fix the […]
That is right. Rather than fixing via type coercion's, a more explicit function parameter validation in the preamble seems sensible. It's not like C's type-system is so rich to allow for bounding the functions domain rigorously imho.
To view, visit change 61545. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifb408c55c3b69ddff453dcc704b7389298050473
Gerrit-Change-Number: 61545
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Comment-Date: Wed, 02 Feb 2022 23:45:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment