Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.

View Change

1 comment:

• File writeprotect.c:

  • Patch Set #6, Line 26: print_wp_chip_state

    I think it's a bit nicer to keep it with the other printing functions that get added at the bottom o […]

    We are making an effort to remove all forward declarations: https://review.coreboot.org/q/project:flashrom+AND+(message:%2522forward+declarations%2522+OR+message:%2522forward+decl%2522+OR+message:%2522forward+decls%2522)
    could be more patches, I just did a quick search.

    I think it's fine to have this function at the top, it is consistent with the rest of codebase.

To view, visit change 58479. To unsubscribe, or for help writing mail filters, visit settings.