Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen.

Patch set 1:Code-Review -1

View Change

3 comments:

• Patchset:

  • Patch Set #1:

    I believe you that the issue is real, but I think the solution is not correct. We need to find the right solution.

  • Patch Set #1:

    as long as we need it, we should include it

    We don't need lifecycle.h here :) Let's debug the issue properly.

    I am super suspicious of this:
    > error: type of ‘selfcheck_board_matches_table’ defaults to ‘int’ [-Werror=implicit-int]

    First of all , which options did you use for compiling? CHROMIUM repository might have slightly different compiler options set up.
    Also, was CONFIG_INTERNAL enabled?

• Commit Message:

  • Patch Set #1, Line 9:

    selfcheck.c is using the macro SKIP_TEST, so we should include the
    header lifecycle.h
    

    SKIP_TEST is defined in `include/test.h` , which is already included.
    `lifecycle.h` is not relevant to SKIP_TEST neither to selfcheck. If you look into lifecycle.h you can see it has functions for programmer lifecycle, this is why all programmer tests have it.

    Here it is not needed.

    I believe you that you see an error on your environment, but lifecycle.h is not the solution. We need to figure out why exactly the error is happening.

To view, visit change 83219. To unsubscribe, or for help writing mail filters, visit settings.