Edward O'Callaghan has uploaded this change for review.

View Change

tests/: Add spi.c unit tests

Change-Id: Ie97c818c3f427bfb438ac3023fa4d1bfe1bec8f0
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
---
M tests/meson.build
A tests/spi.c
M tests/tests.c
M tests/tests.h
4 files changed, 63 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/41644/1

diff --git a/tests/meson.build b/tests/meson.build
index 0c21cb9..5af0a3e 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -2,6 +2,7 @@
 
 srcs = [
   'tests.c',
+  'spi.c',
 ]
 
 mocks = [
diff --git a/tests/spi.c b/tests/spi.c
new file mode 100644
index 0000000..fda3903
--- /dev/null
+++ b/tests/spi.c
@@ -0,0 +1,53 @@
+#include <include/test.h>
+#include "tests.h"
+
+#include "programmer.h"
+
+#include <string.h>
+
+
+static int mock_spi_send_command(const struct flashctx *flash,
+		unsigned int write_count,
+		unsigned int read_count,
+		const unsigned char *write_buffer,
+		unsigned char *read_buffer)
+{
+	return 0xAA55;
+}
+
+void registered_masters_test_success(void **state)
+{
+	(void) state; /* unused */
+
+	static struct spi_master mst = {
+		.max_data_read = 16,
+		.max_data_write = 8,
+		.command = mock_spi_send_command,
+		.multicommand = default_spi_send_multicommand,
+		.read = default_spi_read,
+		.write_256 = default_spi_write_256,
+		.write_aai = default_spi_write_aai,
+	};
+	assert_int_not_equal(register_spi_master(&mst), ERROR_FLASHROM_BUG);
+
+	struct spi_master *master = &registered_masters[0].spi;
+	assert_int_equal(master->max_data_read, 16);
+	assert_int_equal(master->max_data_write, 8);
+	assert_int_equal(master->command(NULL,0,0,NULL,NULL), 0xAA55);
+}
+
+void programmer_init_test_success(void **state)
+{
+	(void) state; /* unused */
+
+	assert_int_equal(
+		programmer_init(
+			CONFIG_DEFAULT_PROGRAMMER,
+			strdup(CONFIG_DEFAULT_PROGRAMMER_ARGS)
+		), 0
+	);
+
+	struct flashrom_flashctx flashctx = { 0, };
+	int ret = probe_flash(&registered_masters[0], 0, &flashctx, 0);
+	assert_int_not_equal(ret, -1);
+}
diff --git a/tests/tests.c b/tests/tests.c
index ded39de..338646e 100644
--- a/tests/tests.c
+++ b/tests/tests.c
@@ -18,5 +18,11 @@
 {
 	int ret = 0;
 
+	const struct CMUnitTest spi_tests[] = {
+		cmocka_unit_test(registered_masters_test_success),
+		cmocka_unit_test(programmer_init_test_success),
+	};
+	ret |= cmocka_run_group_tests_name("spi.c tests", spi_tests, NULL, NULL);
+
 	return ret;
 }
diff --git a/tests/tests.h b/tests/tests.h
index b088e24..ccc3f5e 100644
--- a/tests/tests.h
+++ b/tests/tests.h
@@ -1,4 +1,7 @@
 #ifndef TESTS_H
 #define TESTS_H
 
+void registered_masters_test_success(void **state);
+void programmer_init_test_success(void **state);
+
 #endif /* TESTS_H */

To view, visit change 41644. To unsubscribe, or for help writing mail filters, visit settings.