Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
View Change
1 comment:
File spidriver.c:
Patch Set #4, Line 307: fw_version >= 2
Just to double-check, it's 2 as it's also described on line 267 above? […]
Only version 2 supports setting the SPI mode, I don't have a version 1 device so the condition does nothing for me when testing
To view, visit change 86411. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b
Gerrit-Change-Number: 86411
Gerrit-PatchSet: 4
Gerrit-Owner: Simon Arlott <flashrom.simon@arlott.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Mon, 10 Mar 2025 12:25:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>