Attention is currently required from: Nico Huber, Henry Sun, Paul Menzel, Tao Xia, Angel Pons, Weimin Wu, Anastasia Klimchuk, Karthik Ramasubramanian.
View Change
2 comments:
File flashchips.c:
Patch Set #4, Line 6: only
Probably an accidental edit?
Patch Set #4, Line 8368:
/* OTP: 512B total; enter 0xB1, exit 0xC1
8K-bit total for MX25L12833F only */
No strong opinion, but this might be clearer if all sizes are given in bytes, e.g.
/* OTP: MX25L12833F has 1KB total, others have 512B total; enter 0xB1, exit 0xC1 */
To view, visit change 56546. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I14ab7e04f5209d2bcf34b0d2de9da2c01bf32d00
Gerrit-Change-Number: 56546
Gerrit-PatchSet: 4
Gerrit-Owner: Tao Xia <xiatao5@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Henry Sun <henrysun@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: Weimin Wu <wuweimin@huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Ginger Zhang <zhangqingchun@huaqin.corp-partner.google.com>
Gerrit-CC: Krystal Han <hanlijing@huaqin.corp-partner.google.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Henry Sun <henrysun@google.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Tao Xia <xiatao5@huaqin.corp-partner.google.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Weimin Wu <wuweimin@huaqin.corp-partner.google.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 04:13:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment