Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File layout.c:

  • Patch Set #2, Line 139: || file == NULL

    This is wrong. `file` is allowed to be NULL since it's optional (see line 130-135). […]

    Just rethinking.. I would still merge this with lines 132-135 but I would leave lines 132-135 where they are. So I would just expand lines 132-135. The check for the colon and the second parameter should happen after line 131.

To view, visit change 70006. To unsubscribe, or for help writing mail filters, visit settings.