Attention is currently required from: Dmitry Zhadinets, Peter Marheine.

2 comments:

Patchset:
- Patch Set #2:
  I think that this change is not needed because the code has become more complex […]
  I can see what you mean by saying the code is more complex. But I think we should be using our own API wherever it's applicable: it gives an example of correct usage to people, and also can help to detect breakage.
  I just looked and it's a bit sad that the other functions print_supported_* are not using libflashrom :( I think it's better to gradually change them one by one and maybe in future have them all using libflashrom.
Commit Message:
- Patch Set #2, Line 9:
```
Testing: Both unit tests and CLI tools serve as libflashrom clients.
    All unit tests run successfully.
```
  I have a suggestion instead of these two lines (which are true but very generic) add testing info which is specific to the patch.
  Concretely, in this case running `flashrom -h` (help) or `flashrom -L` (info on what's supported) will run the code which this patch is changing.
  So instead I suggest something like:
  Testing: `flashrom -h` and `flashrom -L` both print the list of supported programmers successfully

To view, visit change 87195. To unsubscribe, or for help writing mail filters, visit settings.