Attention is currently required from: Richard Hughes.
View Change
1 comment:
File tests/chip.c:
Patch Set #6, Line 86: struct progress_user_data *progress_user_data = progress_state->user_data;
Thanks heaps for all details! Very useful. […]
After implementing the new version of callback API I realised it is better to be as a separate patch (so, instead of updating this patch I created new one, see CB:86031 )
The reason is, the new implementation basically undoes changes in this patch, updates the API, and commit message needs to be fully changed too. So my plan is to abandon this patch, and continue the work in CB:86031
To view, visit change 64663. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010
Gerrit-Change-Number: 64663
Gerrit-PatchSet: 6
Gerrit-Owner: Richard Hughes <richard@hughsie.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Peter Marheine <pmarheine@chromium.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Richard Hughes <richard@hughsie.com>
Gerrit-Comment-Date: Fri, 17 Jan 2025 08:36:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>