Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Peter Marheine.
Patch set 2:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #1:
That's a good idea, and I forgot about TLDR in README. I added there too. […]
I would agree that when developers see the sequence "setup", "compile", "test", "install". They can figure out that if they do not need the binaries in their /usr/local/bin or wherever, they will skip the final "install" command, or if they to not care about running tests (on un-modified source code maybe), then they will skip the "test" step. I do not think it is necessary to explicitly call out either as being optional.
To view, visit change 78689. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I67d5f4decdac15e6a72f4372135dab7d44396594
Gerrit-Change-Number: 78689
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Jes Klinke <jbk@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Mon, 30 Oct 2023 16:28:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>
Comment-In-Reply-To: Alexander Goncharov <chat@joursoir.net>
Gerrit-MessageType: comment