Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File util/ich_descriptors_tool/ich_descriptors_tool.c:

  • Patch Set #1, Line 87: uint32_t

    > I would prefer doing variable declarations at the beginning of the method, so that these are not s […]

    NB. Using write(2) like this is not correct because it can be interrupted
    and return a short write count even on success. One is supposed to call it
    in a loop until all data is written. Such interruptions are very rare, hence
    code written like this works more than 99.9% of the time (at least on Linux;
    I've little experience with other OSs).

    Not sure if there is any reason to use the low-level functions here. Using
    fwrite(3) would avoid such problems.

To view, visit change 63488. To unsubscribe, or for help writing mail filters, visit settings.