Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

2 comments:

• File buspirate_spi.c:

  • Patch Set #2, Line 54: bp_

    The `bp_` prefix seems unnecessary now.

    Yes sure, I usually do this as separate patch - so now there is CB:54886 on the top of the chain.

  • Patch Set #2, Line 167: struct buspirate_spi_data *buspirate_data = data;

    Thank you so much for detailed explanation, and I am really sorry for delay from my side! During las […]

    After some more thinking, I did this:
    I really wanted to keep as much optimisations from the Author as possible, but also reduce noise and diffs because that was the suggestion which started this thread.
    So bp_data is still spi_master data (keeps optimisations), but I use a shortcut local variable in most of functions (reduce noise and diffs).

To view, visit change 52958. To unsubscribe, or for help writing mail filters, visit settings.