Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello.
1 comment:
Patchset:
So the test code and the programmer driver used different definitions
of `struct pci_dev`? If that's the case, we should decide on one and
use that IMHO :)
Suggestion:
Either we make libpci a dependency for the tests, then we can include
<pci/pci.h> in the test code. Or not, then we should mock the file,
i.e. move `struct pci_dev` into a `tests/include/pci/pci.h` and make
sure that we look there first when compiling the driver code. Instead
of wrapping the functions, we would provide them under their original
names and wouldn't link against libpci at all.
The latter seems more work right now, but would avoid further trouble
with mixed mocks and actual libpci code.
To view, visit change 62845. To unsubscribe, or for help writing mail filters, visit settings.