Attention is currently required from: Angel Pons, Light, Nikolai Artemiev.
View Change
1 comment:
Patchset:
Patch Set #4:
Heh, a third solution comes to mind. Sorry if this is getting too
theoretical. Just ignore this comment at your convenience. ;)
Prove that it can't happen and ignore the tool. I think that is possible. My reasoning:
- If `bp_bit_count == 0`, then `bp == 0` and the error path isn't taken.
- If `bp_bit_count == 1`, then either `bp == 0` or `bp == 1 == bp_max` and the error path isn't taken.
To view, visit change 62733. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad
Gerrit-Change-Number: 62733
Gerrit-PatchSet: 4
Gerrit-Owner: Light <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Light <aarya.chaumal@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 18:16:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment