Nico Huber merged this change.

View Change

Approvals: Nico Huber: Verified Angel Pons: Looks good to me, approved
libflashrom: Add CPP guard to fix big-endian builds

Calm a compiler warning on big-endian builds about the unused static
flashrom_layout_parse_fmap(). The guard is ugly but gets the job done.
We should forbid endian-specific code in the future, I guess.

Change-Id: Id3f4a57e027f88cc469ed50312adddcc8af71a63
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/33297
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M libflashrom.c
1 file changed, 2 insertions(+), 0 deletions(-)

diff --git a/libflashrom.c b/libflashrom.c
index f90a22c..c327c62 100644
--- a/libflashrom.c
+++ b/libflashrom.c
@@ -383,6 +383,7 @@
#endif
}

+#ifdef __FLASHROM_LITTLE_ENDIAN__
static int flashrom_layout_parse_fmap(struct flashrom_layout **layout,
struct flashctx *const flashctx, const struct fmap *const fmap)
{
@@ -414,6 +415,7 @@
*layout = l;
return 0;
}
+#endif /* __FLASHROM_LITTLE_ENDIAN__ */

/**
* @brief Read a layout by searching the flash chip for fmap.

To view, visit change 33297. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: Id3f4a57e027f88cc469ed50312adddcc8af71a63
Gerrit-Change-Number: 33297
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged