Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Stefan Reinauer.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 12: * Incorporate missing region names from https://github.com/coreboot/coreboot/blob/main/util/ifdtool/ifdtool.c for completeness.

    Thank you for syncing region names in two places! I am curious, is there any official doc from Intel on the region names?
    I see that the names are from coreboot code, which is good. But I assume coreboot code was written based on some doc? Do you happen to know?

• File ich_descriptors.c:

  • Patch Set #1, Line 521: msg_pdbg2(" FD BIOS ME GbE Pltf DE BIOS2 Reg7 EC DE2 ");

    For this line (and diffs below in this file) you have changed the number of spaces between names? So now the whole line is shown as diff, even though the first 5 names haven't changed.
    If there a reason to change the number of spaces?

To view, visit change 81356. To unsubscribe, or for help writing mail filters, visit settings.