Attention is currently required from: Simon Arlott.

View Change

2 comments:

• File doc/classic_cli_manpage.rst:

  • Patch Set #2, Line 359: spidriver

    I am thinking about naming, maybe excamera_spidriver will be better? I understand that SPIDriver is […]

    I agree that it seems pretty generic at first glance, but I think `spidriver` is okay. We use product names without the vendor name for most other devices, and `spidriver` would be a very poor name for a device that isn't named that. The documentation is also clear that it's the Excamera Labs device, so I'm happy to leave it this way.

• File spidriver.c:

  • Patch Set #2, Line 136: /* Read and write */

    I am just curious, there is a way to write, or the way to read and write, but no way to only read? I […]

    I assume that's just because of how SPI works, since the periperhal always shifts bits in from the host on clock transitions. If you're not actually writing data, you need to agree with the peripheral that it will ignore whatever data you send.

To view, visit change 86411. To unsubscribe, or for help writing mail filters, visit settings.