Attention is currently required from: Simon Buhrow, Nico Huber, Edward O'Callaghan, Aarya.
2 comments:
Patchset:
Do you mean CB:65844
Yes, the correct patch to merge into is CB:65844. It already contains 3 patches squashed, and let's add 4th patch there too.
The idea is to have one patch with everything for `erasure_layout.h` and `erasure_layout.c`.
I have few style comments to `erase_write` function code, but I think it would be easier for you if I add them after you squash. So that the comments and resolution are in the same patch.
File erasure_layout.c:
//execute erase
erasefunc_t *erasefn = lookup_erase_func_ptr(erase_layout[i].eraser);
ret = erasefn(flashctx, start_addr, block_len);
if (ret) {
msg_cerr("Failed to execute erase command for offset %#x to %#x.\n", start_addr, start_addr + block_len);
ret = -1;
goto _end;
}
//adjust curcontents
memset(curcontents+start_addr, erased_value, block_len);
//after erase make it unselected again
erase_layout[i].layout_list[j].selected = false;
msg_cdbg("E(%x:%x)", start_addr, start_addr + block_len - 1);
//verify erase
ret = check_erased_range(flashctx, start_addr, block_len);
if (ret) {
msg_cerr("Verifying flash. Erase failed for range %#x : %#x, Abort.\n", start_addr, start_addr + block_len - 1);
goto _end;
}
What is the `region` in that patch?
Given that CB:70517 is merged, I guess the comment can be resolved.
To view, visit change 66104. To unsubscribe, or for help writing mail filters, visit settings.