Attention is currently required from: Jonathan Zhang.
View Change
1 comment:
Patchset:
Patch Set #1:
> I'm not talking about the detection. I mean if anybody checked that […]
Note: I checked Purley and Whitley BKC images and they use 0x8b (139) as the ISL value, according to `ifdtool`. I also checked a couple other EBG BKC images and they use 0x50 (80). Both Whitley and Purley use the Lewisburg chipset.
So for Lewisburg I think we should check for both 80 and 139.
To view, visit change 54965. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2a1bb7467e693d1583aa885fa0e277075edd4a3e
Gerrit-Change-Number: 54965
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9@fb.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Comment-Date: Sun, 12 Sep 2021 21:55:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com>
Gerrit-MessageType: comment