Anastasia Klimchuk submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved
tests/chip.c: Set MOCK_CHIP_CONTENT non-ambiguously

A chip content setup as 0x00 is ambiguous from a zero'ed heap
or some erased chips and 0xFF is ambiguous from an erased chip.

Change-Id: I15905180141aee54c166ff1c0275d1a7dfde0a46
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/71826
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
---
M tests/chip.c
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/tests/chip.c b/tests/chip.c
index 1d9cdc9..580f4ea 100644
--- a/tests/chip.c
+++ b/tests/chip.c
@@ -37,7 +37,7 @@
#include "programmer.h"

#define MOCK_CHIP_SIZE (8*MiB)
-#define MOCK_CHIP_CONTENT 0xff
+#define MOCK_CHIP_CONTENT 0xCC /* 0x00 is a zeroed heap and 0xFF is an erased chip. */

static struct {
unsigned int unlock_calls; /* how many times unlock function was called */

To view, visit change 71826. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15905180141aee54c166ff1c0275d1a7dfde0a46
Gerrit-Change-Number: 71826
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Evan Benn <evanbenn@google.com>
Gerrit-MessageType: merged