Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Subrata Banik.

View Change

1 comment:

• File include/programmer.h:

  • Patch Set #1, Line 364: /* All chipsets after METEOR_LAKE should support checking BIOS_BM to get read/write access to of FREG0~15 */

    We attempted to move METEOR_LAKE to the bottom of the ich_chipset enum, but this patch reveals that many usages still rely on the existing order:
    ```
    	case CHIPSET_METEOR_LAKE:
    	case CHIPSET_PANTHER_LAKE:
    	case CHIPSET_APOLLO_LAKE:
    	case CHIPSET_GEMINI_LAKE:
    	case CHIPSET_JASPER_LAKE:
    	case CHIPSET_ELKHART_LAKE:
    ```

    Based on your expertise, which order would be more logical and maintainable? Could you provide insights on the factors that should be considered when determining the ideal order?

To view, visit change 83144. To unsubscribe, or for help writing mail filters, visit settings.