Attention is currently required from: Felix Singer, Angel Pons.

View Change

1 comment:

• File ichspi.c:

  • Patch Set #7, Line 872: write_cmd = true;

    > I like the idea, but this doesn't block the submission of the patches right? […]

    And there is really no need to write walls of text because of this change.
    Especially not when it's repeating generic arguments that don't even apply
    to this case.

    As Anastasia pointed out: "Renaming only comes up for this one file (two
    variables in here), not for every patch in the chain." I think it would
    have taken less than 1% of the time we spent to discuss this to change
    this one commit. There seems to be not a single patch in this chain that
    depends on it, so no rebase necessary (`rebase` btw. is a Git command,
    Git can do that for us, no hard manual work needed, unless there are
    conflicts, which are rare).

To view, visit change 66892. To unsubscribe, or for help writing mail filters, visit settings.