Attention is currently required from: Thomas Heijligen, Evan Benn.

View Change

2 comments:

• Commit Message:

  • Patch Set #11, Line 14: TEST=meson test; ninja llvm-cov-tests

    Can you test scenario when feature disables? when tests disabled?
    Obviously, when feature disabled then coverage is not measured. The point of testing is to check flashrom builds and runs normally (without coverage and/or tests).
    And please add those to the test scenarios in commit message. Thanks!

• File meson.build:

  • Patch Set #5, Line 534: if get_option('llvm_cov')

    coverage can be used independently of unit tests

    I am confused, but what does it mean, coverage without running tests?

To view, visit change 69268. To unsubscribe, or for help writing mail filters, visit settings.