Attention is currently required from: Felix Singer, Nico Huber, Martin L Roth, Anastasia Klimchuk, Nikolai Artemiev.
View Change
1 comment:
File flashrom.8.tmpl:
Patch Set #8, Line 1182: terminates at the end-point
I have one question: does this mean unspecified target […]
It is undocumented behavior. Some servo configurations may auto pick AP, sometimes just fail, previous state seems to impact it so ultimately the termination at the USB end-point is undefined from the looks of things.
This is why on line 1170 I said "must be specified". Unfortunately there is some scripts that exist that relies on this non-explicit undocumented behavior so we cannot change the code to hard fail when "target" is unspecified so easily. Therefore we document here what is known and how it *should* be used.
To view, visit change 62768. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I186920006bdfcc7a9f89542f84b452dfc72b18e4
Gerrit-Change-Number: 62768
Gerrit-PatchSet: 8
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin L Roth <martinroth@google.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Martin L Roth <martinroth@google.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Tue, 03 May 2022 02:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment