Patch Set 3:

After some sleep, this looks good to me now. This is also much closer to what the code looked like before I wrote combine_image_by_layout().

For the future, I wonder, should we normalize the "UI" layout to something where we can make better assumptions? e.g. sort the regions, merge overlapping/directly following regions and fill gaps with non-included regions

sounds good. Maybe it can even be extended to handle things like read and write protected regions?

View Change

To view, visit change 30370. To unsubscribe, or for help writing mail filters, visit settings.