Attention is currently required from: Felix Singer.
View Change
1 comment:
File 82802ab.c:
Patch Set #11, Line 25: #include <stdbool.h>
Anything to do here? Or can this comment be marked as resolved?
Would be good to discuss it. IMHO, I'd like to avoid including basic type headers (stdbool, stdint, stddef...) in every file, but include one header like coreboot's types.h
Marking as resolved as this should be addressed in a follow-up.
To view, visit change 66879. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5dfd9ed4856c37dd70706b2dd71fbb9a8acbdf4c
Gerrit-Change-Number: 66879
Gerrit-PatchSet: 11
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Comment-Date: Wed, 07 Sep 2022 11:12:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment